Add 'asset-pipeline-gradle, grails-datastore-gorm-mongodb and views-gradle to grails-bom`
#13872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeconsole
requested changes
Nov 22, 2024
| @@ -25,6 +25,7 @@ ext { | |||
| // version name = versionNameOverride ?: artifactId-prefixes[0] | |||
| dependenciesOverview = """\ | |||
| com.bertramlabs.plugins:asset-pipeline-grails:: | |||
| com.bertramlabs.plugins:asset-pipeline-gradle:: | |||
There was a problem hiding this comment.
you are not using SCOTL format. Shouldn't that be com.bertramlabs.plugins:asset-pipeline:gradle,grails: ? or is there a chance the version numbers won't match? I don't think they have ever been released independently.
There was a problem hiding this comment.
This is intentional. They have indeed been out of sync. There is for example no 4.4.0 version of asset-pipeline-grails
mattias@mattias-z4-linux:~/test/g622app$ mcs com.bertramlabs.plugins:asset-pipeline-grails:4*
Searching for com.bertramlabs.plugins:asset-pipeline-grails:4*...
Found 7 results
Coordinates Last updated
=========== ============
com.bertramlabs.plugins:asset-pipeline-grails:4.5.2 07 Nov 2024 at 19:38 (CET)
com.bertramlabs.plugins:asset-pipeline-grails:4.5.1 25 Jul 2024 at 18:00 (CEST)
com.bertramlabs.plugins:asset-pipeline-grails:4.5.0 25 Jul 2024 at 17:11 (CEST)
com.bertramlabs.plugins:asset-pipeline-grails:4.3.0 01 May 2023 at 18:20 (CEST)
com.bertramlabs.plugins:asset-pipeline-grails:4.2.0 11 Apr 2023 at 17:36 (CEST)
com.bertramlabs.plugins:asset-pipeline-grails:4.1.0 03 Mar 2023 at 17:57 (CET)
com.bertramlabs.plugins:asset-pipeline-grails:4.0.0 03 Nov 2022 at 16:29 (CET)
mattias@mattias-z4-linux:~/test/g622app$ mcs com.bertramlabs.plugins:asset-pipeline-gradle:4*
Searching for com.bertramlabs.plugins:asset-pipeline-gradle:4*...
Found 8 results
Coordinates Last updated
=========== ============
com.bertramlabs.plugins:asset-pipeline-gradle:4.5.1 25 Jul 2024 at 18:00 (CEST)
com.bertramlabs.plugins:asset-pipeline-gradle:4.5.0 25 Jul 2024 at 17:11 (CEST)
com.bertramlabs.plugins:asset-pipeline-gradle:4.4.0 26 Sep 2023 at 22:24 (CEST)
com.bertramlabs.plugins:asset-pipeline-gradle:4.3.0 01 May 2023 at 18:20 (CEST)
com.bertramlabs.plugins:asset-pipeline-gradle:4.2.0 11 Apr 2023 at 17:36 (CEST)
com.bertramlabs.plugins:asset-pipeline-gradle:4.1.0 03 Mar 2023 at 17:57 (CET)
com.bertramlabs.plugins:asset-pipeline-gradle:4.0.0 03 Nov 2022 at 16:29 (CET)
com.bertramlabs.plugins:asset-pipeline-gradle:4.5.2 07 Nov 2024 at 19:38 (CET)| @@ -21,10 +21,11 @@ org.gradle.parallel=true | |||
| org.gradle.daemon=true | |||
| org.gradle.jvmargs=-Dfile.encoding=UTF-8 -Xmx1536M -XX:MaxMetaspaceSize=1024M | |||
|
|
|||
| # Generated on Tue Oct 22 16:16:30 EDT 2024 by: ./gradlew :grails-bom:syncProps | |||
| # Generated on Fri Nov 22 09:58:56 CET 2024 by: ./gradlew :grails-bom:syncProps | |||
There was a problem hiding this comment.
+2 points for running the task 😉
codeconsole
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up dependency versions in
grails-views, I noticed these versions are not in the BOM.I see no reason why they should not be. They are all core dependencies.